Skip to content
This repository has been archived by the owner on May 10, 2019. It is now read-only.

https://browserid.org/signup is broken #1429

Closed
lloyd opened this issue Apr 12, 2012 · 3 comments
Closed

https://browserid.org/signup is broken #1429

lloyd opened this issue Apr 12, 2012 · 3 comments

Comments

@lloyd
Copy link
Contributor

lloyd commented Apr 12, 2012

this is in production after the push of train-2012.03.28. the signup page on browserid.org doesn't work, as the call to stage_user includes a domain rather than an origin, which interacts poorly with our new input parameter checking on the stage_user call.

Further, an Internal Server Error is returned, rather than a clearer 40x error messages which describes what inputs were bad.

@ghost ghost assigned lloyd Apr 12, 2012
@jbonacci
Copy link
Contributor

Verified on Stage. This makes me angry. QA should have caught this. This was the one release where I did not try the Sign Up because there is so little traffic through here...

lloyd added a commit that referenced this issue Apr 12, 2012
…rmed, not 500 (internal server error). issue #1429 issue #1423
lloyd added a commit that referenced this issue Apr 12, 2012
…breaking code that expected it to be an origin, like /signup which invokes the stage_user api, which now validates the 'site' parameter is a properly formed origin. issue #1429
lloyd added a commit that referenced this issue Apr 12, 2012
…breaking code that expected it to be an origin, like /signup which invokes the stage_user api, which now validates the 'site' parameter is a properly formed origin. issue #1429
lloyd added a commit that referenced this issue Apr 12, 2012
…rmed, not 500 (internal server error). issue #1429 issue #1423
lloyd added a commit that referenced this issue Apr 12, 2012
…breaking code that expected it to be an origin, like /signup which invokes the stage_user api, which now validates the 'site' parameter is a properly formed origin. issue #1429

Conflicts:

	resources/static/shared/user.js
lloyd added a commit that referenced this issue Apr 12, 2012
…rmed, not 500 (internal server error). issue #1429 issue #1423
lloyd added a commit that referenced this issue Apr 12, 2012
…breaking code that expected it to be an origin, like /signup which invokes the stage_user api, which now validates the 'site' parameter is a properly formed origin. issue #1429

Conflicts:

	resources/static/shared/user.js
@lloyd lloyd closed this as completed Apr 12, 2012
@lloyd
Copy link
Contributor Author

lloyd commented Apr 12, 2012

to be deployed today in 0.2012.03.28.7

@jbonacci
Copy link
Contributor

Verified in Stage and in Prod.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants