Skip to content
This repository has been archived by the owner on May 10, 2019. It is now read-only.
This repository has been archived by the owner on May 10, 2019. It is now read-only.

diresword.org returns "You are offline" (Stock browser, Android 2.3.4) #719

Closed
jrgm opened this issue Dec 7, 2011 · 6 comments
Closed

Comments

@jrgm
Copy link
Contributor

jrgm commented Dec 7, 2011

Steps to reproduce:

  1. ensure that stock browser is set as default
  2. got to http://beta.myfavoritebeer.org
  3. Sign in (popup goes to https://diresworb.org

Expected:
Dialog to either sign up (if not already) or to pick browserid to use;
RP window switches to logged-in state after that is done.

Actual:
Browser shows error message: "You are offline". [But on a few very
rare occasions, this has worked correctly, but ~1 in 25 times].

Phone:
Galaxy S II
Internet (stock browser) 2.3.4
Android 2.3.4 GINGERBREAD XWKI4

@ghost ghost assigned shane-tomlinson Dec 15, 2011
@lloyd
Copy link
Contributor

lloyd commented Dec 16, 2011

I saw this while trying to dev locally last night. i also saw this in google chrome when starting the browser up while offline, then switching to online.

Maybe this disabling is too aggressive.

What is this check designed to catch? the case where include.js is in your browser cache, lots of resources are there, but you are offline?

Would handling a failure to get session_context be a more effective means of providing good user feedback when bid servers aren't reachable?

@lloyd
Copy link
Contributor

lloyd commented Dec 20, 2011

stomlinson, shall we just remove the offline check and close this issue?

@shane-tomlinson
Copy link

@lloyd - I think that is a prudent choice for now.

@ghost ghost assigned lloyd Dec 28, 2011
@lloyd
Copy link
Contributor

lloyd commented Dec 28, 2011

stealing

@lloyd lloyd closed this as completed in 161936c Dec 28, 2011
@jrgm
Copy link
Contributor Author

jrgm commented Jan 5, 2012

not seeing with issue anymore with browser 2.3.4 on android 2.3.4 Galaxy II SE (which was showing me the offline UI before).

fmarier pushed a commit to fmarier/browserid that referenced this issue Jan 28, 2012
…ozilla#719 (@shane-tomlinson - I went for a minimal fix given we're branching the beta train right after this commit.  feel free to clean up)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants
@lloyd @jrgm @shane-tomlinson and others