This repository has been archived by the owner on May 10, 2019. It is now read-only.
issue 3067 - don't require caller to have curry on Function prototype #3069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd click the merge button if the target was b2g. Or maybe we're just going straight to dev now... |
|
Thanks, @seanmonstar - i could be thinking of this the wrong way, but i'm proposing it to dev so it can be pulled both into b2g and branch we're using for desktop firefox for picl. I thought this would be easier, and it seems like a valid bug for dev anyway. |
seanmonstar
added a commit
that referenced
this pull request
Mar 5, 2013
issue 3067 - don't require caller to have curry on Function prototype
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow the pattern of using a
completefunction within theinternal_apicallbacks so that use ofcurryis confined to the dialog.This is important in a context like b2g or desktop firefox, where callbacks are handed from the browser to the
internal_api; they should not need to modify the Function prototype.