Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new rule for detecting potential performance-related bugs #2305

Merged
merged 19 commits into from Feb 1, 2024

Conversation

PromiseFru
Copy link
Collaborator

New rule for detecting potential performance-related bugs.

Checklist

  • Type annotations added to new functions
  • Docs added to functions touched in main classes
  • Dry-run produced the expected results
  • The to-be-announced tag added if this is worth announcing

@PromiseFru PromiseFru marked this pull request as draft December 19, 2023 17:32
@PromiseFru PromiseFru marked this pull request as ready for review January 19, 2024 12:18
@PromiseFru
Copy link
Collaborator Author

Dry-Run

Hi there,

    <p>
The following bugs are probably performance related and don't have performance impact value:

Bug Summary Confidence (%)
1876285 Constant high cpu & gpu usage + framerate degredation on beatport.com 25
1876263 See how much we can optimize `all` transition handling. 24
1876157 Nightly-as-release builds are slower than regular Nightly builds (not PGO'ing properly) 35
1876051 test_fetch perf test takes a long time with http/3 28
1875469 High CPU use on gmail.com due to exzessive window.message usage (blocking other tabs from loading) 32

Sincerely,
BugBot

See the search query on Bugzilla.

    <p>
        See the source / report issues on the <a href="https://github.com/mozilla/bugbot/">GitHub repo</a>
    </p>
</body>

@suhaibmujahid suhaibmujahid self-requested a review January 29, 2024 21:56
bugbot/rules/performancebug.py Outdated Show resolved Hide resolved
bugbot/rules/performancebug.py Outdated Show resolved Hide resolved
bugbot/rules/performancebug.py Outdated Show resolved Hide resolved
bugbot/rules/performancebug.py Outdated Show resolved Hide resolved
bugbot/rules/performancebug.py Outdated Show resolved Hide resolved
bugbot/rules/performancebug.py Outdated Show resolved Hide resolved
configs/rules.json Outdated Show resolved Hide resolved
configs/rules.json Show resolved Hide resolved
Copy link
Member

@suhaibmujahid suhaibmujahid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the CI :)

bugbot/rules/performancebug.py Show resolved Hide resolved
bugbot/rules/performancebug.py Outdated Show resolved Hide resolved
suhaibmujahid
suhaibmujahid previously approved these changes Feb 1, 2024
Copy link
Member

@suhaibmujahid suhaibmujahid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM. Could you please add the rule to the daily tasks (in the scripts/cron_run_daily.sh file)?

@suhaibmujahid suhaibmujahid merged commit 6966638 into mozilla:master Feb 1, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants