Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include new rule for detecting accessibility related bugs #2308

Merged
merged 8 commits into from
Feb 5, 2024

Conversation

jpangas
Copy link
Collaborator

@jpangas jpangas commented Dec 21, 2023

This PR includes a new rule to detect accessibility related bugs using the accesibility model.

Checklist

  • Type annotations added to new functions
  • Docs added to functions touched in main classes
  • Dry-run produced the expected results
  • The to-be-announced tag added if this is worth announcing

@jpangas jpangas marked this pull request as ready for review January 29, 2024 09:06
@jpangas jpangas marked this pull request as draft January 29, 2024 09:06
@jpangas jpangas marked this pull request as ready for review January 31, 2024 14:52
Copy link
Member

@suhaibmujahid suhaibmujahid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @jpangas! Please see my comments.

configs/rules.json Outdated Show resolved Hide resolved
templates/accessibility.html Outdated Show resolved Hide resolved
bugbot/rules/accessibility.py Outdated Show resolved Hide resolved
bugbot/rules/accessibility.py Outdated Show resolved Hide resolved
bugbot/rules/accessibility.py Outdated Show resolved Hide resolved
configs/rules.json Outdated Show resolved Hide resolved
suhaibmujahid
suhaibmujahid previously approved these changes Feb 2, 2024
Copy link
Member

@suhaibmujahid suhaibmujahid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, John! LGTM. Could you please confirm the dry-run results?

bugbot/rules/accessibilitybug.py Show resolved Hide resolved
@jpangas
Copy link
Collaborator Author

jpangas commented Feb 5, 2024

The DRY-RUN results

Hi there,

The following bug is probably accessibility related :

Bug Summary Confidence (%)
1877302 Update a11y review documentation to reference assigned value 26

Sincerely,
BugBot

See the search query on Bugzilla.

See the source / report issues on the GitHub repo

@suhaibmujahid suhaibmujahid merged commit 6ebc889 into mozilla:master Feb 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants