-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
'Is reporter a developer' as a feature #83
Comments
I have a couple of questions about this.
|
|
|
Sounds good, it should work. You'll need to make this smarter: You can check the number of arguments to the function, and if the number of arguments is only 1 you only pass the bug, otherwise, you pass an object containing some data (for now, only the developers). |
Good idea! |
|
I prefer the more generic solution |
@poojan124 are you working on this? |
No as of now I am not working on this. Was stuck on how to send extra data to required features. |
@marco-c thanks . now since we have added |
Sorry for the late reply. I need clarification on a couple of things.
Above list is
|
'Is reporter a developer' as a feature mozilla#83
@marco-c Please review and comment whether this is a correct implementation of the feature or i need to change? |
Yes, for now we can use this solution. We can improve on it later by using information from https://hg.mozilla.org/mozilla-central/file/tip/.mailmap, and by trying to match the full name from the commit with the full name from Bugzilla. Could you regenerate the list, putting the commit hash alongside the invalid emails? I want to take a look at a few of the commits with invalid authors. |
Can you give me a reference from where can I get this commit hash? |
I hope this is ok: https://pastebin.com/raw/mgu3vRzv. Since I don't know where to get those commit hash i have created this file from |
Yeah that is fine too, from the bug ID I can retrieve the commit. |
@marco-c so are we going with this implementation or need to change anything? |
Yes, it's OK as a first implementation. |
@marco-c Ok then i will make PR.
And will also look into better way to extract author list from commit data. |
'Is reporter a developer' as a feature mozilla#83
We can get author email or name directly using
This way of extracting email is lot better than using regex. Which one do you prefer? UPD: https://pastebin.com/ZJ4i8GR8 This is generated commit.json file using the above template. |
This would definitely be better, but I'd be curious to see what are author_name and author_email in those cases where the email was missing. |
|
OK, thanks for the investigation! |
Similar to #30.
This feature is going to be a boolean saying whether the reporter of the bug is a developer. As a first implementation, we can check if there is any commit where they are authors.
The text was updated successfully, but these errors were encountered: