New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.so and .dylib should be cleaned up to as DLLs #89

Closed

marco-c opened this issue Jan 21, 2019 · 1 comment

Labels

feature-extraction good-first-bug reserved-for-beginners

Collaborator

marco-c commented Jan 21, 2019

.so and .dylib are DLLs on Linux and Mac. We should replace them with DLL_NAME as we do for .dll files.

marco-c added good-first-bug reserved-for-beginners labels

dbxnr mentioned this issue

expand cleanup_dll() regex to match .so and .dylib #96

Merged

Collaborator Author

marco-c commented Jan 23, 2019

Fixed by #96.

marco-c closed this as completed

marco-c added the feature-extraction label

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment