Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calibrated the Regressor Model #3450

Merged
merged 13 commits into from May 7, 2023
Merged

Conversation

WhiteWolf47
Copy link
Contributor

This PR aims to calibrate the Regressor model using the IsotonicRegressionCalibrator class from the model_calibration.py file.

Copy link
Member

@suhaibmujahid suhaibmujahid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @WhiteWolf47! Could you please share the performance reports here (for the before and after)?

bugbug/models/regressor.py Outdated Show resolved Hide resolved
@WhiteWolf47
Copy link
Contributor Author

@suhaibmujahid here are the reports -

before calibration -
output.txt

after calibration -
output_cal.txt

suhaibmujahid
suhaibmujahid previously approved these changes Apr 24, 2023
Copy link
Member

@suhaibmujahid suhaibmujahid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, LGTM!

bugbug/models/regressor.py Outdated Show resolved Hide resolved
suhaibmujahid
suhaibmujahid previously approved these changes May 6, 2023
@suhaibmujahid suhaibmujahid requested a review from marco-c May 6, 2023 01:59
bugbug/models/regressor.py Outdated Show resolved Hide resolved
marco-c
marco-c previously approved these changes May 6, 2023
@WhiteWolf47 WhiteWolf47 dismissed stale reviews from marco-c and suhaibmujahid via 98f5a17 May 7, 2023 07:31
@suhaibmujahid suhaibmujahid merged commit 4819447 into mozilla:master May 7, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants