Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for specific Docker tag in spawn_data_pipeline.py #489

Merged
merged 3 commits into from May 24, 2019
Merged

Add support for specific Docker tag in spawn_data_pipeline.py #489

merged 3 commits into from May 24, 2019

Conversation

Lothiraldan
Copy link
Contributor

This is needed in #340. We can either compute the Docker image like I do in this PR or pass the Docker Tag as context as the JSON file is rendered as JSON-e. I have a small preference for the way of this PR as we don't need to put the logic logic or env.DOCKER_TAG in all of the pipelines files.

@Lothiraldan Lothiraldan requested a review from marco-c May 24, 2019 09:47
marco-c
marco-c previously approved these changes May 24, 2019
View reviewed changes
Copy link
Collaborator

@marco-c marco-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a slight preference towards the JSON-e solution, because it allows you to force the tag you want (e.g. maybe you want some images with the tag and some without the tag), but for now this works for all our purposes so 👍.

@marco-c marco-c merged commit 6e7c815 into master May 24, 2019
@Lothiraldan Lothiraldan deleted the spawn-pipeline-docker-tag branch May 24, 2019 10:53
marco-c added a commit that referenced this pull request May 24, 2019
@marco-c
Revert "Add support for specific Docker tag in spawn_data_pipeline.py (…
c5a11a7 
…#489)"

This reverts commit 6e7c815.
@marco-c marco-c mentioned this pull request May 24, 2019
Merged
marco-c added a commit that referenced this pull request May 24, 2019
@marco-c
Revert "Add support for specific Docker tag in spawn_data_pipeline.py (…
249ed40 
…#489)" (#499)

This reverts commit 6e7c815.
@marco-c marco-c mentioned this pull request May 24, 2019
Open
Lothiraldan added a commit that referenced this pull request Jun 6, 2019
@Lothiraldan
Revert "Revert "Add support for specific Docker tag in spawn_data_pip…
e89de39 
…eline.py (#489)" (#499)"

This reverts commit 249ed40.
marco-c pushed a commit that referenced this pull request Jun 6, 2019
@Lothiraldan @marco-c
Add support for specific Docker tag in spawn_data_pipeline.py (#553)
5a31c99 
* Revert "Revert "Add support for specific Docker tag in spawn_data_pipeline.py (#489)" (#499)"

This reverts commit 249ed40.

* Ignore task with a tagged docker image

* Restrict Docker tag update to bugbug related images
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marco-c marco-c marco-c approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Lothiraldan @marco-c