-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Metas view, add logo header, new styles, cleanup old cruft #294
Conversation
I'll take a look through this tomorrow morning! 👍🏻 |
Re: removing the unused components - I remember that the last time I spoke to Scott about it (it was a while ago tbf) the Pocket folks were still actively using Bugzy for triage. I still think we should do this, but it would be nice to reach out and give them a heads up && ask if they're up to maintaining their own fork. I've pinged Scott to see if he knows :) ETA: We're good! |
cb4661b
to
ebe9cf0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's looking good! You addressed everything I noticed on the fly so this is just R+ :)
(we should probably have some tests tho)
Thanks!
Agreed - filed #298 |
I tried disentangling these commits into separate PRs, but it's a bit too complicated, with too many overlapping changes. I think it's best to just merge without squashing, so that each commit is preserved individually in the history.
Features
Style
Fix/Refactor
Cleanup
BugList::render
toBugList::children
for a few components