Issue 301 - Increase contrast between P1 and P2 labels #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Remember to add Fixes #301 to your pull request descriptions or extended commit messages, it helps with tracking and it'll automatically close the issue when the PR merges. Btw, I use dark reader so I judge the colors by how well they work in both light mode & dark reader haha. So you may want to test with both light & dark also. |
aminomancer
reviewed
May 4, 2024
| border-color: transparent; | ||
| color: white; | ||
| } | ||
| .p2 { | ||
| background: #9fc6ee; | ||
| background: #9FC6EE; |
There was a problem hiding this comment.
I'm confused. These are the same colors, just in uppercase?
There was a problem hiding this comment.
Sorry I don't know what happened to the modified colors but I'll update the colors again anyway to work in both light and dark mode.
aminomancer
approved these changes
May 6, 2024
|
Feel free to merge - make sure to hit "Squash and merge" and not the other options. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #301
These are the screenshots showing the new colors chosen for the priority labels. The colors have been adjusted to work in both light and dark mode (using dark reader).