This repository has been archived by the owner on Jun 5, 2020. It is now read-only.
Bug 1191717: set puppet server; r=rail #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rail
pushed a commit
that referenced
this pull request
Aug 18, 2015
Bug 1191717: set puppet server; r=rail
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows spot instantiation is failing at this step with:
2015-08-18 07:36:20,226 - Spot request for y-2008-spot-001.try.releng.use1.mozilla.com (0.4)
2015-08-18 07:36:20,227 - Cannot start
Traceback (most recent call last):
File "aws_watch_pending.py", line 266, in do_request_spot_instances
is_spot=True, dryrun=dryrun, all_instances=all_instances)
File "aws_watch_pending.py", line 320, in do_request_instance
"region_dns_atom": get_region_dns_atom(region)})
File "/builds/aws_manager/cloud-tools/cloudtools/aws/instance.py", line 311, in user_data_from_template
user_data = user_data.format(**tokens)
KeyError: 'puppet_server'
This PR will hopefully fix this issue.