use %s so that we get pretty-printing in logs

mozilla · Mar 27, 2015 · cd6e0d2 · cd6e0d2
1 parent 9e512dd
commit cd6e0d2
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/fwunit/analysis/sources.py b/fwunit/analysis/sources.py
@@ -34,7 +34,7 @@ def rulesForApp(self, app):
     def rulesDeny(self, src, dst, apps):
         src = _ipset(src)
         dst = _ipset(dst)
-        log.info("rulesDeny(%r, %r, %r)" % (src, dst, apps))
+        log.info("rulesDeny(%s, %s, %r)" % (src, dst, apps))
         failures = 0
         apps = apps if not isinstance(apps, basestring) else [apps]
         for app in apps:
@@ -60,7 +60,7 @@ def rulesDeny(self, src, dst, apps):
     def rulesPermit(self, src, dst, apps):
         src = _ipset(src)
         dst = _ipset(dst)
-        log.info("rulesPermit(%r, %r, %r)" % (src, dst, apps))
+        log.info("rulesPermit(%s, %s, %r)" % (src, dst, apps))
         remaining = IPPairs((src, dst))
         apps = apps if not isinstance(apps, basestring) else [apps]
         for app in apps:
@@ -82,7 +82,7 @@ def rulesPermit(self, src, dst, apps):
     def allApps(self, src, dst, debug=False):
         src = _ipset(src)
         dst = _ipset(dst)
-        log.info("allApps(%r, %r)" % (src, dst))
+        log.info("allApps(%s, %s)" % (src, dst))
         rv = set()
         for rule in itertools.chain(*self.rules.itervalues()):
             if not debug and rule.app in rv:
@@ -103,7 +103,7 @@ def allApps(self, src, dst, debug=False):
 
     def sourcesFor(self, dst, app, ignore_sources=None):
         dst = _ipset(dst)
-        log.info("sourcesFor(%r, %r, ignore_sources=%r)" % (dst, app, ignore_sources))
+        log.info("sourcesFor(%s, %r, ignore_sources=%s)" % (dst, app, ignore_sources))
         rv = IPSet()
         for rule in self.rulesForApp(app):
             if rule.dst & dst: