Skip to content
This repository has been archived by the owner on Sep 15, 2021. It is now read-only.

Commit

Permalink
bug 753629 - fix uploads for release Android single locale repacks wi…
Browse files Browse the repository at this point in the history
…th build > 1. r=nthomas
  • Loading branch information
escapewindow committed May 10, 2012
1 parent 177ff44 commit 35a9aa7
Show file tree
Hide file tree
Showing 7 changed files with 11 additions and 7 deletions.
2 changes: 1 addition & 1 deletion configs/single_locale/release_mozilla-aurora_android.py
Expand Up @@ -59,7 +59,7 @@
"UPLOAD_TO_TEMP": "1", "UPLOAD_TO_TEMP": "1",
"MOZ_PKG_VERSION": "%(version)s", "MOZ_PKG_VERSION": "%(version)s",
}, },
"base_post_upload_cmd": "post_upload.py -p mobile -n 1 -v %(version)s --builddir android/%(locale)s --release-to-mobile-candidates-dir --nightly-dir=candidates", "base_post_upload_cmd": "post_upload.py -p mobile -n %(buildnum)s -v %(version)s --builddir android/%(locale)s --release-to-mobile-candidates-dir --nightly-dir=candidates",
"merge_locales": True, "merge_locales": True,
"make_dirs": ['config'], "make_dirs": ['config'],
"mozilla_dir": MOZILLA_DIR, "mozilla_dir": MOZILLA_DIR,
Expand Down
2 changes: 1 addition & 1 deletion configs/single_locale/release_mozilla-beta_android.py
Expand Up @@ -59,7 +59,7 @@
"UPLOAD_TO_TEMP": "1", "UPLOAD_TO_TEMP": "1",
"MOZ_PKG_VERSION": "%(version)s", "MOZ_PKG_VERSION": "%(version)s",
}, },
"base_post_upload_cmd": "post_upload.py -p mobile -n 1 -v %(version)s --builddir android/%(locale)s --release-to-mobile-candidates-dir --nightly-dir=candidates", "base_post_upload_cmd": "post_upload.py -p mobile -n %(buildnum)s -v %(version)s --builddir android/%(locale)s --release-to-mobile-candidates-dir --nightly-dir=candidates",
"merge_locales": True, "merge_locales": True,
"make_dirs": ['config'], "make_dirs": ['config'],
"mozilla_dir": MOZILLA_DIR, "mozilla_dir": MOZILLA_DIR,
Expand Down
2 changes: 1 addition & 1 deletion configs/single_locale/release_mozilla-release_android.py
Expand Up @@ -59,7 +59,7 @@
"UPLOAD_TO_TEMP": "1", "UPLOAD_TO_TEMP": "1",
"MOZ_PKG_VERSION": "%(version)s", "MOZ_PKG_VERSION": "%(version)s",
}, },
"base_post_upload_cmd": "post_upload.py -p mobile -n 1 -v %(version)s --builddir android/%(locale)s --release-to-mobile-candidates-dir --nightly-dir=candidates", "base_post_upload_cmd": "post_upload.py -p mobile -n %(buildnum)s -v %(version)s --builddir android/%(locale)s --release-to-mobile-candidates-dir --nightly-dir=candidates",
"merge_locales": True, "merge_locales": True,
"make_dirs": ['config'], "make_dirs": ['config'],
"mozilla_dir": MOZILLA_DIR, "mozilla_dir": MOZILLA_DIR,
Expand Down
Expand Up @@ -58,7 +58,7 @@
"UPLOAD_TO_TEMP": "1", "UPLOAD_TO_TEMP": "1",
"MOZ_PKG_VERSION": "%(version)s", "MOZ_PKG_VERSION": "%(version)s",
}, },
"base_post_upload_cmd": "post_upload.py -p mobile -n 1 -v %(version)s --builddir android/%(locale)s --release-to-mobile-candidates-dir --nightly-dir=candidates", "base_post_upload_cmd": "post_upload.py -p mobile -n %(buildnum)s -v %(version)s --builddir android/%(locale)s --release-to-mobile-candidates-dir --nightly-dir=candidates",
"merge_locales": True, "merge_locales": True,
"make_dirs": ['config'], "make_dirs": ['config'],
"mozilla_dir": MOZILLA_DIR, "mozilla_dir": MOZILLA_DIR,
Expand Down
Expand Up @@ -58,7 +58,7 @@
"UPLOAD_TO_TEMP": "1", "UPLOAD_TO_TEMP": "1",
"MOZ_PKG_VERSION": "%(version)s", "MOZ_PKG_VERSION": "%(version)s",
}, },
"base_post_upload_cmd": "post_upload.py -p mobile -n 1 -v %(version)s --builddir android/%(locale)s --release-to-mobile-candidates-dir --nightly-dir=candidates", "base_post_upload_cmd": "post_upload.py -p mobile -n %(buildnum)s -v %(version)s --builddir android/%(locale)s --release-to-mobile-candidates-dir --nightly-dir=candidates",
"merge_locales": True, "merge_locales": True,
"make_dirs": ['config'], "make_dirs": ['config'],
"mozilla_dir": MOZILLA_DIR, "mozilla_dir": MOZILLA_DIR,
Expand Down
Expand Up @@ -58,7 +58,7 @@
"UPLOAD_TO_TEMP": "1", "UPLOAD_TO_TEMP": "1",
"MOZ_PKG_VERSION": "%(version)s", "MOZ_PKG_VERSION": "%(version)s",
}, },
"base_post_upload_cmd": "post_upload.py -p mobile -n 1 -v %(version)s --builddir android/%(locale)s --release-to-mobile-candidates-dir --nightly-dir=candidates", "base_post_upload_cmd": "post_upload.py -p mobile -n %(buildnum)s -v %(version)s --builddir android/%(locale)s --release-to-mobile-candidates-dir --nightly-dir=candidates",
"merge_locales": True, "merge_locales": True,
"make_dirs": ['config'], "make_dirs": ['config'],
"mozilla_dir": MOZILLA_DIR, "mozilla_dir": MOZILLA_DIR,
Expand Down
6 changes: 5 additions & 1 deletion scripts/mobile_l10n.py
Expand Up @@ -387,13 +387,17 @@ def upload_repacks(self):
version = self.query_version() version = self.query_version()
upload_env = self.query_upload_env() upload_env = self.query_upload_env()
success_count = total_count = 0 success_count = total_count = 0
buildnum = None
if c.get('release_config_file'):
rc = self.query_release_config()
buildnum = rc['buildnum']
for locale in locales: for locale in locales:
if self.query_failure(locale): if self.query_failure(locale):
self.warning("Skipping previously failed locale %s." % locale) self.warning("Skipping previously failed locale %s." % locale)
continue continue
total_count += 1 total_count += 1
if c.get('base_post_upload_cmd'): if c.get('base_post_upload_cmd'):
upload_env['POST_UPLOAD_CMD'] = c['base_post_upload_cmd'] % {'version': version, 'locale': locale} upload_env['POST_UPLOAD_CMD'] = c['base_post_upload_cmd'] % {'version': version, 'locale': locale, 'buildnum': str(buildnum)}
output = self.get_output_from_command( output = self.get_output_from_command(
# Ugly hack to avoid |make upload| stderr from showing up # Ugly hack to avoid |make upload| stderr from showing up
# as get_output_from_command errors # as get_output_from_command errors
Expand Down

0 comments on commit 35a9aa7

Please sign in to comment.