Skip to content
This repository has been archived by the owner on Jan 20, 2022. It is now read-only.

Require a special permission for clobbering. #34

Merged
5 commits merged into from Apr 15, 2015
Merged

Require a special permission for clobbering. #34

5 commits merged into from Apr 15, 2015

Conversation

ghost
Copy link

@ghost ghost commented Apr 8, 2015

No description provided.

@djmitche
Copy link
Contributor

djmitche commented Apr 8, 2015

This bit looks good -- the other methods are informational, so they don't need auth.

I can't quite piece together what route the buildslaves use, but that's probably due to under-caffeination..

@Callek
Copy link
Contributor

Callek commented Apr 8, 2015

...still failing

@ghost
Copy link
Author

ghost commented Apr 9, 2015

@Callek At last!

@Callek
Copy link
Contributor

Callek commented Apr 9, 2015

👍 looking through this, I'm satisfied, but I am not a huge fan of the perm name (though I can't think of any better naming),

AND I'd love if the test_context didn't always have that perm, and instead only added the perm for the tests that need it (and have tests that the perm itself is required to use those endpoints).

That way you ensure the no-perm-needed endpoints stay no-perm-needed (until you conciously decide they need a perm) and you get tests that the perm-needed-ones stay perm needed, also explicitly.

I'm ok if thats a followup.

@ghost
Copy link
Author

ghost commented Apr 9, 2015

Fair, I'll change the perm name to clobberer.post.clobber and modify the test context.

@ghost
Copy link
Author

ghost commented Apr 15, 2015

I'm going to need to come back to the test context later. It's giving me troubles that I fear may become a rabbit hole. In the near term, having security is more important.

ghost pushed a commit that referenced this pull request Apr 15, 2015
Require a special permission for clobbering.
@ghost ghost merged commit dd50f1e into mozilla:master Apr 15, 2015
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants