This repository has been archived by the owner on Jan 20, 2022. It is now read-only.
Bug 1164878 - Allow users without an authenticated_email field to clo… #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bber The TokenUser is not anonymous, but also has no e-mail address associated with it. When this combination occurs, a who value of 'automation' should be supplied, instead of outright failing. While not exact, the term automation gives us a way to categorize clobbers that seemed to be authenticated by a permanent token (as opposed to a user token).
|
👍 assuming Travis likes it too |
|
Looks like one more test case should get the coverage back up.. |
ghost
pushed a commit
that referenced
this pull request
May 28, 2015
Bug 1164878 - Allow users without an authenticated_email field to clo…
ghost
merged commit
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…bber
The TokenUser is not anonymous, but also has no e-mail address associated with it.
When this combination occurs, a who value of 'automation' should be supplied, instead
of outright failing.
While not exact, the term automation gives us a way to categorize clobbers that seemed
to be authenticated by a permanent token (as opposed to a user token).