This repository has been archived by the owner on Jan 19, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 26
Patch for issue #48 Enable logging of SQL statements #173
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -18,7 +18,10 @@ | |
from sqlalchemy.orm import scoping | ||
from sqlalchemy.pool import Pool | ||
|
||
|
||
# db logging | ||
logger = logging.getLogger(__name__) | ||
logging.basicConfig() | ||
|
||
|
||
class _QueryProperty(object): | ||
|
@@ -75,6 +78,10 @@ def _get_db_config(self, dbname): | |
|
||
@synchronized(threading.Lock()) | ||
def engine(self, dbname): | ||
# Get the log level for db logs | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. To avoid multiple logger for sql engine, I thought it would better to create it when the db is getting created. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, I think this makes sense. |
||
if self.app.config.get('SQLALCHEMY_DB_LOG'): | ||
logging.getLogger('sqlalchemy.engine').setLevel(logging.INFO) | ||
|
||
if dbname not in self._engines: | ||
uri = self._get_db_config(dbname) | ||
self._engines[dbname] = sa.create_engine(uri) | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From what I can see, sqlalchemy always logs at the INFO level. So I think this is more flexibility than the user needs, and your earlier use of a boolean flag is probably the best solution.