This repository has been archived by the owner on Jan 19, 2022. It is now read-only.
Add setting for celery logging #179
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| from flask import current_app | ||
| from werkzeug.local import LocalProxy | ||
|
|
||
| _defined_tasks = {} | ||
| _relengapi_log_lvl = None # Used for celery log level |
There was a problem hiding this comment.
I don't like this because it's independent of any particular app.
Does current_app work from the after_setup_logger signal? Alternately, can you read RELENGAPI_CELERY_LOG_LEVEL from celery.conf during that signal hook?
|
@djmitche is this better/acceptable? (if so I can adjust docs and see about testing, in near future.) |
|
Yes, very nice! |
|
@Callek -- ping re testing/docs? |
|
@Callek ping? I'd like to get 2.0.0 out soon, but this still needs testing and docs.. |
|
Also, this would be really handy for me in debugging tooltool :) |
|
@djmitche fwiw I don't expect to get to the docs/testing part of this, this week. If you want to pick this up and run with it by all means. Otherwise I expect to round it out early in April |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a desire to use debug logging for celery for relengapi, but I wanted it without the added global debugging (using
celery worker --loglevel debugadds loads of other output) (my current solution has beenprintwhich is sub-par)Basically I just wanted relengapi.* to log in debug mode. I got the general idea for this approach from http://www.toforge.com/2011/06/celery-centralized-logging/
The structure of it stemmed mostly from needed to have the signal setup before celery fully instantiates (calls its signals), but after the relengapi app is setup, and in a spot that the signal can actually access the app.
This code would need docs and test(s) if it was to be merged in, but I wanted a 👍 for the general idea first. @djmitche or @mrrrgn . What do you think?