This repository has been archived by the owner on Jan 19, 2022. It is now read-only.
Enable logging of SQL statements #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove trailing spaces new logger add sqlalchemy flag echo_pool for sqlalchemy logging remove typo error update sqlalchemy log correct indentation remove print statement update sqlalchemy logging
|
@Callek in Rahul's absence, r? |
|
@djmitche Is more changes required in this? |
|
I don't think so -- I was asking you if the result looked good. Do you see anything else that isn't complete? |
|
Looks ok to me, I didn't test though. 👍 |
djmitche
added a commit
to djmitche/build-relengapi
that referenced
this pull request
Apr 7, 2015
|
@djmitche It is woking fine on my local system. 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves #48, using @rahulrrixe's commit from #173.
Rahul, what do you think?