This repository has been archived by the owner on Jan 4, 2019. It is now read-only.
Add task/run/buildrequest ids to logs where appropriate #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -74,25 +74,25 @@ def handleStarted(self, data, msg): | |||
| try: | |||
| task = self.bbb_db.getTaskFromBuildRequest(brid) | |||
| except TaskNotFound: | |||
| log.debug("Task not found for brid %s (%s), nothing to do.", brid, buildername) | |||
| log.debug("buildrequest %s: task not found for builder %s, nothing to do.", brid, buildername) | |||
| continue | |||
There was a problem hiding this comment.
nit:
else:
log.debug("buildrequest %s: found task %s", brid, task)There was a problem hiding this comment.
or maybe also include buildername here somehow?
|
Overall, looks great, had a few nits that I think improves things, but this is good to land now. |
|
My nits were not blocking, will followup on that |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.