Skip to content
This repository has been archived by the owner on Aug 4, 2022. It is now read-only.

Test that pings are deleted following deletion-request #55

Open
hackebrot opened this issue Jul 13, 2020 · 7 comments
Open

Test that pings are deleted following deletion-request #55

hackebrot opened this issue Jul 13, 2020 · 7 comments
Labels
capability New capability for burnham or burnham-bigquery discussion Issues for discussing ideas for features test scenario New end-to-end test scenario
Milestone

Comments

@hackebrot
Copy link
Collaborator

Verify that the Data Platform deletes Glean telemetry for a client.

This test is slightly different from other tests as we may need to run a sequence of steps:

  • produce Glean telemetry
  • verify that it's available in BigQuery tables
  • submit deletion-request ping
  • verify that the telemetry for this client has been deleted
@hackebrot hackebrot added capability New capability for burnham or burnham-bigquery discussion Issues for discussing ideas for features labels Jul 13, 2020
@hackebrot hackebrot added this to the Future work milestone Jul 13, 2020
@hackebrot hackebrot added this to To do 📝 in End-to-end tests 🚀 via automation Jul 13, 2020
@jklukas
Copy link
Contributor

jklukas commented Jul 13, 2020

verify that the telemetry for this client has been deleted

Note that the pipeline runs shredder on a 28-day schedule, so it could take several weeks for a deletion request to result in pings being deleted, which could make this a difficult case to test.

@hackebrot
Copy link
Collaborator Author

Do you think it makes sense to create a new DAG on a schedule that matches the shredder pipeline schedule?

@jklukas
Copy link
Contributor

jklukas commented Aug 3, 2020

Do you think it makes sense to create a new DAG on a schedule that matches the shredder pipeline schedule?

Yes, we could pursue that option. I'm not sure if there's a good way to express "wait several weeks" before running the query task to validate the relevant data is gone. We might need to have two DAGs where the first is for submitting a test deletion request, and the other is offset by several weeks, running the query to validate. Or perhaps we have one DAG, and the task that validates data has been deleted references the previous DAG run.

In any of these cases, the long delays are going to make it very hard to iterate on the tests, particularly when they're first set up.

@mdboom
Copy link
Contributor

mdboom commented Sep 11, 2020

Also useful would be to test that once we see a deletion-request ping, we don't see any further pings from that client.

@hackebrot
Copy link
Collaborator Author

Relevant documentation https://mozilla.github.io/glean/book/user/pings/deletion_request.html

The following code is expected to trigger a deletion-request ping:

Glean.set_upload_enabled(False)

Can you confirm that @mdboom, please?

@badboy
Copy link
Member

badboy commented Sep 30, 2020

On @mdboom's behalf:
Yes, disabling upload triggers a deletion-request ping (and removes other pending pings and resets the client ID)

@hackebrot hackebrot changed the title Add test for deletion-request Test that pings are deleted following deletion-request Sep 30, 2020
@hackebrot
Copy link
Collaborator Author

I created #77 for your suggestion @mdboom.

@hackebrot hackebrot removed this from To do 📝 in End-to-end tests 🚀 Oct 1, 2020
@hackebrot hackebrot added the test scenario New end-to-end test scenario label Oct 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
capability New capability for burnham or burnham-bigquery discussion Issues for discussing ideas for features test scenario New end-to-end test scenario
Projects
None yet
Development

No branches or pull requests

4 participants