This repository has been archived by the owner on Aug 4, 2022. It is now read-only.
Update code checks for burnham and burnham-bigquery 🤖 #93
Labels
CircleCI
Tasks related to managing CircleCI
code quality
Tasks related to linting, coding style, type checks
docker
Tasks related to building Docker images
We recently merged a pull-request from Dependabot that introduced incompatible dependencies for burnham (#84). As a consequence we cannot push new Docker images to GKE because the Docker workflow fails.
@jklukas correctly pointed out in #88 (comment) that we need checks that exercise the build workflow.
We currently run the following code checks on CircleCI (see config file):
All of these run in a tox environment. As a first step, I suggest we update the installation step to also install from
requirements.txt
so that any dependency conflict is detected there. I also think we should build the Docker images for pull-requests.According to the documentation of the CircleCI orb that we use for the Docker workflows, we should be able to add a
gcp-gcr/build-image
step. Ideally it will only run if the respective subdirectories are modified.The text was updated successfully, but these errors were encountered: