Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement and document implied-by #72

Open
Gankra opened this issue May 3, 2022 · 1 comment
Open

Implement and document implied-by #72

Gankra opened this issue May 3, 2022 · 1 comment
Labels
p3 do later

Comments

@Gankra
Copy link
Contributor

Gankra commented May 3, 2022

You can have your custom criteria imply the builtins (so you can have stronger criteria), but I don't currently see a way to have custom criteria be "implied by" the builtins (so you can have weaker criteria).

Unclear if this matters / is intentional, but it's a weird asymmetry I figured I'd mention in case you hadn't thought about it.

@bholley
Copy link
Collaborator

bholley commented May 17, 2022

Good point. Would it be trivial in our current implementation to introduce a companion implied-by to support edges in the other direction? We could defer actually implementing it until someone needs it.

@bholley bholley added the question Further information is requested label May 17, 2022
@bholley bholley changed the title [book] is it ok that builtin criteria can't "imply" other criteria? Implement and document implied-by Jun 15, 2022
@bholley bholley changed the title Implement and document implied-by Implement and document implied-by Jun 15, 2022
@bholley bholley added p2 do soon p3 do later and removed question Further information is requested p2 do soon labels Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3 do later
Projects
None yet
Development

No branches or pull requests

2 participants