Upgrade clap 3 to clap 4 #847
Conversation
This also removes the dependency on the unmaintained crate atty. Closes mozilla#828
|
What is the current minimum supported Rust version for clap 4? Currently the msrv for cbindgen is 1.57, so that would presumably need to be bumped too. |
|
@jschwe Indeed, thank you. I updated the version in Cargo.toml. Is it ok to increase it, or does cbindgen has a hard MSRV requirement? |
|
As far as I know (but I'm not a maintainer) there currently is no official MSRV policy. I don't know if cbindgen is used in Firefox, but I could imagine the firefox msrv policy applies also to cbindgen:
|
|
Hi! Would it possible to merge this and cut a new release? |
|
Hope I'm not overstepping but pinging @emilio if a merge and release is possible. Sorry otherwise. |
|
The PR breaks the "Test package" test in CI (which I can reproduce locally), therefore I propose reverting it for now in #868. |
the msrv was bumped in in the Cargo.toml mozilla#847 but not in clippy.toml, clippy was complaining at startup and defaulting to 1.57
the msrv was bumped in in the Cargo.toml mozilla#847 but not in clippy.toml, clippy was complaining at startup and defaulting to 1.57
the msrv was bumped in in the Cargo.toml #847 but not in clippy.toml, clippy was complaining at startup and defaulting to 1.57
This also removes the dependency on the unmaintained crate atty.
Closes #828