chore(build): Initial stab at Grunt skeleton #32
Conversation
|
|
See my comments in #31 about the jshint / jscsrc rules. |
|
That changelog script is really awesome, and makes me much happier about the angular-style commit conventions! |
| Nick Chapman <nchapman@users.noreply.github.com> | ||
| Peter deHaan <peter@deseloper.com> | ||
| Vlad Filippov <vlad.filippov@gmail.com> | ||
| johngruen <john.gruen@gmail.com> |
There was a problem hiding this comment.
@johngruen is this how you want to be remembered by history? If not, maybe hack on your .gitconfig a bit. The user part of mine looks like this:
[user]
name = Jared Hirsch
email = ohai@6a68.net
There was a problem hiding this comment.
Hey Jared, I did locally, but haven't made a PR since.
| @@ -19,6 +21,6 @@ server.route({ | |||
| } | |||
| } | |||
| }); | |||
| server.start(function(request, reply) { | |||
| server.start(function () { | |||
There was a problem hiding this comment.
ehhhhhhh, I dunno. how about inserting /*jshint unused:true */ instead?
There was a problem hiding this comment.
afaik, the server start() method doesn't take parameters, and only routes have request and reply params, not the server start() itself.
http://hapijs.com/api#serverstartcallback
Correction. It looks like server.start() takes a single callback as a paramter with the following signature function (err) {...}. So we may want to add a check for err being non-null and pipe that through heka or something something.
There was a problem hiding this comment.
oh my. let's just leave it as is with your commit, then
There was a problem hiding this comment.
(I'll make sure the server.start actually logs once the server actually does stuff ^_^)
|
ok, looks good to me (modulo concerns I've called out above). feel free to merge once you've addressed my concerns; nchapman can file a followup for any jshint or jscs rules he'd like to change 🍻 |
|
To @nchapman for his eyes and green button pressing skills. |
|
This looks great. Nicely done @pdehaan! |
chore(build): Initial stab at Grunt skeleton
A case study in how not to do pull requests...
But we should now have a shared precommit-hook which runs lint tasks whenever you try and commit some code.
JSHint and JSCS rules are up for negotiation.
FIxes #31
Fixes #17
FIxes #13
Fixes #12
Fixes #11