Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Intermittent failure to handle Amazon #273

Open
Trikolon opened this issue Nov 16, 2023 · 0 comments
Open

Intermittent failure to handle Amazon #273

Trikolon opened this issue Nov 16, 2023 · 0 comments
Labels
broken-rule Cookie banner is not handled on a site because of a broken or outdated rule. rule-temporary-removed

Comments

@Trikolon
Copy link
Member

Now that we only attempt to handle the banner once it becomes more obvious that the banner isn't always properly handled on Amazon.

https://bugzilla.mozilla.org/show_bug.cgi?id=1865196

STR from the bug:

  1. go to private mode, visit amazon.de
  2. open a sub-product page

Expected behavior: I don't see the cookie banner on the product page

Actual behavior: I see the banner
@Trikolon Trikolon added the broken-rule Cookie banner is not handled on a site because of a broken or outdated rule. label Nov 16, 2023
Trikolon added a commit that referenced this issue Nov 17, 2023
@Trikolon
Remove broken Amazon rule.
a4b8b7d 
See: Intermittent failure to handle Amazon #273
Greg-21 pushed a commit to Greg-21/cookie-banner-rules-list-fork that referenced this issue Nov 18, 2023
@Trikolon
Disabled Tumblr, Paypal, Amazon (mozilla#279)
89e431b 
* Allow empty rules for disabling CBH for specific sites.

* Add a "disabled" rule with paypal and tumblr.

Adding domains to an empty rule means the cookie banner handling
mechanism won't run for these sites.

We're removing tumblr.com and paypal.com specifically to ensure we don't
significantly decrease performance on these sites. They may be added
back in the future.

* Remove broken Amazon rule.

See: Intermittent failure to handle Amazon mozilla#273

* Add the validation check for empty rules back, but exclude the disabled rule explicitly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
broken-rule Cookie banner is not handled on a site because of a broken or outdated rule. rule-temporary-removed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Trikolon