Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cnn.com reloads #71

Closed
pdehaan opened this issue Nov 30, 2022 · 3 comments · Fixed by #335
Closed

cnn.com reloads #71

pdehaan opened this issue Nov 30, 2022 · 3 comments · Fixed by #335
Labels
bug Something isn't working

Comments

@pdehaan
Copy link

pdehaan commented Nov 30, 2022

via mozilla/Foxfooding_Cookie_Banner_Handling#2

Firefox Version: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:108.0) Gecko/20100101 Firefox/108.0
Window Size (inner width and height): 1920x947
GitHub Username: @pedroldk

Steps to Reproduce

Go to https://cnn.com

Expected Behavior

The page should not reload.

Actual Behavior

Went to cnn.com and although the site didn't show the cookie banner as expected, the page reloaded. This behaviour might break redirects or pop-ups on some websit

@Trikolon
Copy link
Member

Trikolon commented Dec 1, 2022

Some sites reload after submitting the cookie banner. I don't think we can do much here. Stopping the reload may break the website state and cause more breakage. The reload will only happen the first time we handle the banner.

@Trikolon
Copy link
Member

Trikolon commented Dec 1, 2022

@artines1 do you think this is actionable or should we close the issue?

@artines1
Copy link
Contributor

artines1 commented Dec 1, 2022

I think we shouldn't change the website's behavior after clicking the banner. The reload could be necessary for the site to operate functionally. So, I agree that this isn't actionable at least on the clicking side.

However, we might be able to tackle this by cookie rules. But, it depends on if cookie rules are available for cnn.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants