Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't run CircleCI docker build for pull requests #8

Open
Trikolon opened this issue Oct 19, 2022 · 1 comment
Open

Don't run CircleCI docker build for pull requests #8

Trikolon opened this issue Oct 19, 2022 · 1 comment
Labels
bug Something isn't working sync-script Issues related to our GitHub <-> RemoteSettings sync mechanism.

Comments

@Trikolon
Copy link
Member

It fails and we don't really need it other than for pushes. E.g. see #6
@ahoneiser do you agree, or is there a reason why we need it to run for PRs too?

@Trikolon Trikolon added the bug Something isn't working label Oct 19, 2022
@Trikolon
Copy link
Member Author

Trikolon commented Oct 24, 2022

It looks like it's failing if the PR author or person who merges is doesn't grant CircleCI access to the repository. This is done by logging into CircleCI via GitHub. Seems like an o.k. requirement for Mozillians but doesn't really work for external contributors.
We should consider:

  1. Splitting up the repos and put the syncing script into a separate one.
  2. Not running the CircleCI steps for PRs.

I'm in favor of (1).

@Trikolon Trikolon added the sync-script Issues related to our GitHub <-> RemoteSettings sync mechanism. label Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working sync-script Issues related to our GitHub <-> RemoteSettings sync mechanism.
Projects
None yet
Development

No branches or pull requests

1 participant