Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation & Prettier #6

Merged
merged 8 commits into from
Oct 19, 2022
Merged

Validation & Prettier #6

merged 8 commits into from
Oct 19, 2022

Conversation

Trikolon
Copy link
Member

@Trikolon Trikolon commented Oct 18, 2022

This PR adds local scripts for JSON schema validation and reformatting code via Prettier.

The rule JSON schema is fetched remotely from https://hg.mozilla.org/mozilla-central/raw-file/tip/toolkit/components/cookiebanners/schema/CookieBannerRule.schema.json

Setup via

npm install

Validate rule list JSON:

npm run validate

Check formatting with prettier:

npm run prettier

@Trikolon
Copy link
Member Author

I've also added a GitHub action which runs these scripts.

Copy link
Contributor

@artines1 artines1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this. I don't see any particular issue here. Just have one simple question.

@Trikolon Trikolon merged commit d1faf1a into main Oct 19, 2022
@Trikolon Trikolon deleted the validation branch October 19, 2022 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants