Download artifacts script to use as binary. #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marco-c
reviewed
Aug 20, 2018
download_artifacts.py
Outdated
|
|
||
| from coverage_crawler import latest_cov_build | ||
|
|
||
| latest_cov_build.download_artifacts() |
There was a problem hiding this comment.
We should move the argparse interface from latest_cov_build.py to here too.
There was a problem hiding this comment.
Ok, I'll update this and the other PR on the weekends. :)
|
Thanks for the update! Since we have this script now, we can remove the argparse interface from latest_cov_build.py, so making latest_cov_build.py purely a module. |
|
That is, also removing main from latest_cov_build.py |
|
Will it be possible to import it then? It is not located in |
|
Oh, yep, sorry. I'll remove it now. :) |
marco-c
approved these changes
Aug 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #132