Upload source data before generating mlbf for easier debugging #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mozkeeler
requested changes
Feb 28, 2024
There was a problem hiding this comment.
This seems to be largely the same as [3-upload_mlbf_to_storage](https://github.com/mozilla/crlite/pull/296/files#diff-2af64200fdbc3cf8f17b66f51f3515de134fc381d689ecb1185e100ff63ad816) - was this intended? Is there a way they could share code?
jschanck
force-pushed
the
maintenance
branch
from
e9d04d1
to
d98a606
Compare
mozkeeler
approved these changes
Feb 29, 2024
.pre-commit-config.yaml
Outdated
| @@ -25,11 +25,6 @@ repos: | |||
| language: script | |||
| entry: hooks/go-unit-tests.sh | |||
There was a problem hiding this comment.
go-unit-tests.sh is still used here
jschanck
force-pushed
the
maintenance
branch
from
cbda94c
to
ff9a899
Compare
jschanck
force-pushed
the
maintenance
branch
from
ff9a899
to
d2b7c25
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This splits
workflow/2-upload_artifacts_to_storageintoworkflow/1-upload_data_to_storageandworkflow/3-upload_mlbf-to_storageand makes the former run before the filter generation workflow. The idea here is that if filter generation fails we want to be able to pull the source material from GCP for local debugging.Also a bit of maintenance here to get a base docker image that can run binaries from recent versions of rust. And some changes to make the logs a bit quieter.