Support f32 when using the OpenSLES backend and compiling against older Android SDK #758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
padenot
force-pushed
the
opensl-float-conversion
branch
2 times, most recently
from
16bdf05
to
1e46027
Compare
padenot
force-pushed
the
opensl-float-conversion
branch
3 times, most recently
from
0169acc
to
6fcaea9
Compare
padenot
force-pushed
the
opensl-float-conversion
branch
from
6fcaea9
to
dc519d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the OpenSLES backend is in use, and the application using cubeb has been compiled against an old SDK (before level 21, Lollipop, from 2014), the facilities to configure an audio stream to use floating point PCM isn't available.
This is the case in Firefox for Android, when compiled for armv7 devices, the API level in use is 16.
This PR also includes numerous cleanups on this backend (but the functional change is in its own commit):
cubeb_log.hlogging facilitiesIt seems that, unfortunately, we won't be able to get away with always relying on AAudio, so that seemed worth doing.
This fixes BMO#1848518, but I'm going to send another PR for the input side.