Add SQL style guide #133
Merged
Add SQL style guide #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mreid-moz
reviewed
May 11, 2018
concepts/sql_style.md
Outdated
| ## Reserved Words | ||
|
|
||
| 1. Always use uppercase for reserved keywords like `SELECT`, `WHERE`, or `AS`. | ||
| 1. Always use uppercase for Presto functions, such as `COUNT`, `CARDINALITY`, or `SUBSTR`. |
There was a problem hiding this comment.
I figured out why I dislike uppercase function names - function names are identifiers, so should be treated like tables, fields, or variables (rather than like reserved keywords).
|
|
||
| 1. Use consistent and descriptive identifiers and names. | ||
| 1. Use lower case names with underscores, such as `first_name`. | ||
| Do not use CamelCase. |
There was a problem hiding this comment.
nit: surround CamelCase with backticks
There was a problem hiding this comment.
I've added this to .spelling instead.
concepts/sql_style.md
Outdated
|
|
||
| 1. The opening parenthesis should terminate the line. | ||
| 1. The closing parenthesis should be lined up under | ||
| the first character of the line that starts the multiline construct. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.