Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

separate results collection from posting #14

Merged
merged 3 commits into from Aug 1, 2012

Conversation

Projects
None yet
2 participants
Contributor

k0s commented Jul 31, 2012

No description provided.

@malini malini and 1 other commented on an outdated diff Aug 1, 2012

dzclient/client.py
@@ -106,6 +101,40 @@ def datasets(self):
return datasets
+
+class DatazillaRequest(DatazillaResultsCollection):
+ """
+ Datazilla request object that manages test information and submission.
+
+ Note that the revision id can be 16 characters, maximum.
+
+ """
+
+ @classmethod
+ def create(cls, host, project, oauth_key, oauth_secret, collection):
+ """create a DatazillaRequest instance from a results collection"""
+
+ # get attributes from the collection
+ attributes = inspect.getargspec(foo).args[1:]
@malini

malini Aug 1, 2012

Contributor

foo function isn't defined

@k0s

k0s Aug 1, 2012

Contributor

How embarassing! That's what i get for copy+pasting :(

@malini malini commented on the diff Aug 1, 2012

dzclient/client.py
@@ -41,22 +42,16 @@ def join_results(self, results):
for test_name, values in tests.items():
suite.setdefault(test_name, []).extend(values)
+class DatazillaResultsCollection(object):
@malini

malini Aug 1, 2012

Contributor

Can you add a docstring describing what this collection is?

@k0s

k0s Aug 1, 2012

Contributor

Will do

Jeff Hammel added some commits Aug 1, 2012

@malini malini added a commit that referenced this pull request Aug 1, 2012

@malini malini Merge pull request #14 from k0s/13
separate results collection from posting
7bfc005

@malini malini merged commit 7bfc005 into mozilla:master Aug 1, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment