Support for getting peers and closing transports #12
Conversation
keianhzo
force-pushed
the
get-peers-support
branch
from
ac31665
to
05b7f7e
Compare
lib/Room.js
Outdated
| @@ -816,6 +816,74 @@ class Room extends EventEmitter | |||
| break; | |||
| } | |||
|
|
|||
| case 'getPeers': | |||
There was a problem hiding this comment.
When reading the client code I was pretty confused that the result of this wasnt being used. I did not realize it actually ended up creating consumers. Maybe we should name it something like consumeExistingProducers? We might also want oto use this on joining rather than doing that automatically.
Alternatively, it might be nice to actually just return the list of existing producing peers and have the client request to create producers. (both in this case, and the join case)... Though that might be better for another PR.
There was a problem hiding this comment.
I'm going to refactor existing producers common code but I think it's ok leaving the flow as it is where consumers for existing producers are returned inline, otherwise it's another message that we have to exchange and traverse again the whole peers map for something that we always are going to need to to in both cases.
Maybe I up change the method name to refreshConsumers. The returned peers are used in the join to hold the connection flow until all consumers are received but in this case it doesn't really makes much sense.
keianhzo
force-pushed
the
get-peers-support
branch
from
cfe52fb
to
bbf6682
Compare
keianhzo
force-pushed
the
get-peers-support
branch
from
bbf6682
to
35ee983
Compare
This PR adds support for closing transports from a client and getting the other peers consumers. This is used int he hubs client to recreate transports and consumers/producers when we need to recover from a ICE failure.
Related Hubs-Foundation/hubs#3930