This repository has been archived by the owner on Dec 17, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ToxicWar
commented
Mar 18, 2013
- Rewritten badges_list and awards_list on CBV.
- Removed unused import direct_to_template
- Fix django-badger/issues url (lmorchard -> mozilla)
- Little changes according PEP8
Fix extra spaces
Update template url(support Django 1.5)
Fix kwargs.get problem (kwargs -> self.kwargs)
Changes in here look good to me! I'll defer to @lmorchard for doing a final r? and merging. Thanks! |
Fix extra spaces
Improve AwardsListView
I've been using this branch with a django 1.5 project with a custom user model. Problems encountered:
|
…ng User from django.contrib.auth.models, first try to get the user model using get_user_model(). But this doesn't work in models.py, so using the string from settings for that file - this breaks one place. Also, username doesn't necessarily exist anymore - some spots noted where this occurs
Conflicts: README.rst badger/models.py
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.