Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated travis and tox #94

Merged
merged 1 commit into from
Mar 21, 2018
Merged

Updated travis and tox #94

merged 1 commit into from
Mar 21, 2018

Conversation

raiderrobert
Copy link
Contributor

  • Simplified tox.ini and .travis.yml configs significantly
  • Added Django 2.0-master and pypy3

@EnTeQuAk
Copy link
Contributor

Thanks a lot for the pull request and adding Django 2.0-master and pypy3 support.

I'm not sure I like the simplification though since this removes granularity from our Travis CI setup and removes the ability to follow-up on failures for a specific Django version. Since most failures occur as a result of changes in a Django version rather than incompatibility with Python.

Do you have the time to maybe rollback those changes so that we keep our granularity in Travis CI? Tox really is mostly being used to unify our test-execution while the "what we test" (python version, django version) is controlled via Travis.

@EnTeQuAk EnTeQuAk self-requested a review March 20, 2018 08:56
@raiderrobert
Copy link
Contributor Author

@EnTeQuAk I'd rather not completely roll these back, because the original config is overly complex. I'll take another swing at both simplifying while maintaining the discrete discovery you're after.

@raiderrobert
Copy link
Contributor Author

@EnTeQuAk OK, done with my changes. Please re-review at your leisure.

Copy link
Contributor

@EnTeQuAk EnTeQuAk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's much better, and probably even faster and easier to cache.

Thanks a lot!

@EnTeQuAk EnTeQuAk merged commit 1c150a4 into mozilla:master Mar 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants