Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a "Vary" header for DNT, useful for caching. #1

Merged
merged 1 commit into from
Feb 16, 2017
Merged

Add a "Vary" header for DNT, useful for caching. #1

merged 1 commit into from
Feb 16, 2017

Conversation

eillarra
Copy link
Contributor

No description provided.

@eillarra
Copy link
Contributor Author

@jsocol Can you check this? Thanks!

@jsocol
Copy link

jsocol commented Feb 16, 2017

Hi @eillarra—it might be best to go to the #webdev channel on Mozilla IRC. I haven't been with Mozilla for several years (or touched this in exactly 6)

@jwhitlock
Copy link
Member

I'd say use https://github.com/benspaulding/django-donottrack/, which does have the vary header, but it doesn't look any more maintained.

@jsocol, can you add me to owners on the repo and "John.Whitlock" on PyPI?

@eillarra
Copy link
Contributor Author

@jwhitlock Thanks for the tip, but the repo doesn't seem to be maintained: benspaulding/django-donottrack#1 . Mozilla's repo was the first one I found while Googling, so maybe we can try to bring it back to live...

@jsocol
Copy link

jsocol commented Feb 16, 2017

@jwhitlock Added you on PyPI and removed me, but I don't have admin access to this repo on GH anymore

@mykmelez
Copy link

@jwhitlock Added you on PyPI and removed me, but I don't have admin access to this repo on GH anymore

I've given @jwhitlock admin access to this repo, so he should now be able to handle this pull request.

Copy link
Member

@jwhitlock jwhitlock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 good doc strings, and the vary patch is similar to https://github.com/benspaulding/django-donottrack/blob/master/donottrack/middleware.py

@jwhitlock jwhitlock merged commit f471249 into mozilla:master Feb 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants