Clarify and add tests for GUID changing #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #27 +/- ##
=========================================
+ Coverage 91.51% 92.11% +0.6%
=========================================
Files 7 7
Lines 2805 2855 +50
=========================================
+ Hits 2567 2630 +63
+ Misses 238 225 -13
Continue to review full report at Codecov.
|
linabutler
force-pushed
the
cleanup-guid-changes
branch
from
ec367c3
to
d3fe379
Compare
* If the merged parent's GUID changed, we need to flag its children for reupload, so that the childrens' `parentid` is correct. * If the merged child's GUID changed, we need to flag its parent for reupload, so that the parent's `children` are correct. * It's an error for `Driver::generate_new_guid` to return a GUID that we already merged.
linabutler
force-pushed
the
cleanup-guid-changes
branch
from
d3fe379
to
4c81c81
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As promised. 馃槃 This also takes the good parts of #26 (checking for dupes, changing GUIDs for nodes on both sides, and comments for what we reupload and why).