This repository has been archived by the owner on Apr 2, 2019. It is now read-only.
Fetch userinfos with access token (fixes #80) #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leplatrem
force-pushed
the
80-access-token-userinfos
branch
from
a230c57
to
6127102
Compare
leplatrem
force-pushed
the
80-access-token-userinfos
branch
from
b28edee
to
bcf8714
Compare
leplatrem
changed the title
leplatrem
force-pushed
the
80-access-token-userinfos
branch
from
8afef35
to
c17cfa5
Compare
leplatrem
changed the title
mostlygeek
reviewed
Jan 25, 2018
authn/authn.go
Outdated
| // identity provider. | ||
| func NewAuthenticator(idP string) (Authenticator, error) { | ||
| if !strings.HasPrefix(idP, "https://") { | ||
| return nil, fmt.Errorf("Identity provider %q not supported or has bad format", idP) |
There was a problem hiding this comment.
I think this error message would be better as, fmt.Errorf("Identify provider %q does not use the https scheme", idP). That is clearer what the failure/rejection reason is.
mostlygeek
reviewed
Jan 25, 2018
| } | ||
| return userinfo, nil | ||
| } | ||
|
|
mostlygeek
reviewed
Jan 25, 2018
authn/openid.go
Outdated
| return nil, err | ||
| } | ||
| uri := config.UserInfoEndpoint | ||
| log.Debugf("Fetch user info from %s", uri) |
mostlygeek
approved these changes
Jan 25, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #80
Stretch goals (another PR if necessary)
jwtIssuerto something more generic likeidentifyProvider