Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

store additional metadata in INFO lines #502

Closed
willkg opened this issue Nov 18, 2022 · 2 comments
Closed

store additional metadata in INFO lines #502

willkg opened this issue Nov 18, 2022 · 2 comments

Comments

@willkg
Copy link
Member

willkg commented Nov 18, 2022

We use dump_syms to extract symbol information from binaries for a specific build of some product. The symbol files are then uploaded to the symbol server. At that point, we have no way of knowing which build of what product generated this symbol information. It would be helpful to capture that at the time dump_syms was run. This would help debugging symbol problems, indexing symbols for finding them later, etc.

Maybe there's other information that would be helpful to capture as well? Maybe it's helpful to generalize the problem to "capture additional metadata at the time of symbol file creation and store as key/value pairs in INFO lines"?

Maybe something like:

dump_syms --info=ProductName:Firefox --info=ReleaseChannel:nightly --info=BuildID:20221118000000 -s outputdir libxul.so

Which would then result in a header something like this:

MODULE Linux x86_64 8F91CC4320D4B79F745D18F5D50C46A30 libxul.so
INFO CODE_ID 43CC918FD4209FB7745D18F5D50C46A33009215D
INFO PRODUCTNAME Firefox
INFO RELEASECHANNEL nightly
INFO BUILDID 20221118000000

Or something like that.

@willkg
Copy link
Member Author

willkg commented Oct 11, 2023

Something like this would make it a lot easier to add APIs to the Mozilla Symbols Server to do things like "get all the symbols for build xyz".

gabrielesvelto added a commit to gabrielesvelto/dump_syms that referenced this issue Dec 15, 2023
gabrielesvelto added a commit that referenced this issue Dec 16, 2023
* Add an option to insert custom INFO lines into the output files

This fixes issue #502
@gabrielesvelto
Copy link
Collaborator

This is done, I just need to cut a new releases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants