This repository has been archived by the owner on Feb 20, 2019. It is now read-only.
Fixes minor documentation issues #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -4,22 +4,24 @@ | |||
| Installation | |||
| ============ | |||
|
|
|||
| Download | |||
| ======== | |||
There was a problem hiding this comment.
The diff doesn't show this, but Installation is double-barred (up and down) and I was thinking "Download" and "Configure" should be subsections of "Installation". So, I think it should be ====.
Does that hierarchy make sense to have?
|
r- good start, clean it up, rebase and I'll do another round of reviews. |
* the docs didn't mention the repository, so doing a google search leads you to rfd.org but at that point, you don't know where to get the code or how to download it or anything. * fixes some reST formatting issues and sphinx-docs errors * (cosmetic) removes an unused import in setup.py * tweaks some configure documentation
|
I made some more changes and amended my original commit and the force-pushed that to my fork. That seems to have updated the pull request by adding a commit, but I can't tell if that's "the right way" to modify an existing pull request. Anyhow, r? on the new commit. If what's here is weird, I can nix this pull request and create a new one. |
|
That's the right way, IMO. |
davedash
added a commit
that referenced
this pull request
Sep 15, 2011
Fixes minor documentation issues
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to rfd.org but at that point, you don't know where to get the code or how
to download it or anything.