add support for SequenceExpression, when calling. fixes #113 #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Standard8, would you be interested in helping with reviews here from time to time? Jonathan left and we've previously required that nobody touches the code on their own. I might have to rethink that policy though.. |
mozfreddyb
force-pushed
the
support-sequenceexpression-fix-113
branch
from
3395cdb
to
5837766
Compare
mozfreddyb
force-pushed
the
support-sequenceexpression-fix-113
branch
from
5837766
to
ef4121c
Compare
rpl
reviewed
Mar 17, 2020
mozfreddyb
force-pushed
the
support-sequenceexpression-fix-113
branch
from
25e7b30
to
4c307fa
Compare
rpl
reviewed
Mar 17, 2020
mozfreddyb
force-pushed
the
support-sequenceexpression-fix-113
branch
from
4c307fa
to
a7adf7d
Compare
rpl
approved these changes
Mar 18, 2020
There was a problem hiding this comment.
This looks good to me, and I've also verified locally that this version does fix the test failures in mozilla/addons-linter#3076 as expected.
Approved on my side.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
that might do...