Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The "Study" word from experiment Type help section was entirely removed instead of replaced with "Experiment" word #1204

Closed
SoftVision-PaulOiegas opened this issue Apr 24, 2019 · 3 comments · Fixed by #1251
Labels
Defect https://mozilla.github.io/task-defect-enhancement/ not behaving as expected, regression,crash, error Enhancement new / change to feature or function https://mozilla.github.io/task-defect-enhancement/index.html [QA]:Minor issue Label for QA to mark minor issues logged [QA]:Verified fixed Label for QA to mark verified fixed issues
Milestone

Comments

@SoftVision-PaulOiegas
Copy link

[Affected versions]:

  • Firefox Release 66.0.3 and above
  • Chrome 74.0. and up

[Affected Platforms]:

  • All Windows
  • All Mac
  • All Linux

[Prerequisites]:

  • You are logged in your LDAP account on stage website.

[Steps to reproduce]:

  1. Open the browser with the profile from prerequisites and navigate to "https://stage.experimenter.nonprod.dataops.mozgcp.net" page.
  2. Click the "Create Experiment" button from top right side of the page.
  3. After redirected, click on "Help" blue text button from under the experiment "Type" section.
  4. Observe how are the experiment types named in help message.

[Expected result]:

  • Experiment types are named "Pref-Flip Experiment" and "Add-on Experiment".

[Actual result]:

  • The word "Experiment" was removed after both type names, making the descriptions sound a bit strange especially for Add-on type. ("An Add-on sends a Firefox Add-on...").

[Notes]:

  • The initial naming was "Pref-Flip Study" and "Add-on Study", but it seems that after the global naming replacement was performed, the word "Study" was dropped completely and not replaced in this section.
  • Here is a screenshot of the issue:
    Experimenter issue 1
@SoftVision-PaulOiegas SoftVision-PaulOiegas added the [QA]:Minor issue Label for QA to mark minor issues logged label Apr 24, 2019
@jaredlockhart
Copy link
Collaborator

Ah yep small text change, good catch.

@shell1 shell1 added Defect https://mozilla.github.io/task-defect-enhancement/ not behaving as expected, regression,crash, error Enhancement new / change to feature or function https://mozilla.github.io/task-defect-enhancement/index.html labels Apr 29, 2019
@shell1 shell1 added this to the Backlog milestone Apr 29, 2019
@shell1
Copy link

shell1 commented Apr 29, 2019

+1 minor but in future will need - so putting to fix sooner than later.

@Softvision-RemusDranca
Copy link

I have verified this issue and is no longer reproducible on Experimenter stage "https://stage.experimenter.nonprod.dataops.mozgcp.net/" website after the v2.28.1 stage deployment. The word "experiment" was added for both type names in the experiment Type help section.
Tested on Windows 10x64, Mac 10.14 and Arch Linux 4.16.6 x64.

@Softvision-RemusDranca Softvision-RemusDranca added the [QA]:Verified fixed Label for QA to mark verified fixed issues label May 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Defect https://mozilla.github.io/task-defect-enhancement/ not behaving as expected, regression,crash, error Enhancement new / change to feature or function https://mozilla.github.io/task-defect-enhancement/index.html [QA]:Minor issue Label for QA to mark minor issues logged [QA]:Verified fixed Label for QA to mark verified fixed issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants