Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add link to Analysis Report after enrollment period ends #3066

Closed
jaredlockhart opened this issue Jul 20, 2020 · 3 comments
Closed

Add link to Analysis Report after enrollment period ends #3066

jaredlockhart opened this issue Jul 20, 2020 · 3 comments
Assignees
@tiftran
Labels
Enhancement new / change to feature or function https://mozilla.github.io/task-defect-enhancement/index.html P1 - High Priority Should be prioritized into current batch of work. Web UI

Comments

@jaredlockhart
Copy link
Collaborator

After the enrollment period is complete, a link to an analysis report will become available. We need to add it to the detail page. We should probably put a placeholder that says 'your analysis report will become available on such and such date' and then replace that with the real link when it's ready. It'll be a predictable url that includes the slug. Blocking on @tdsmith to provide the root URL.
@jaredlockhart jaredlockhart added Blocked Enhancement new / change to feature or function https://mozilla.github.io/task-defect-enhancement/index.html Web UI labels Jul 20, 2020
@tdsmith
Copy link
Contributor

tdsmith commented Jul 20, 2020

https://metrics.mozilla.com/protected/experiments/{{ slug }}.html

@jaredlockhart jaredlockhart added P1 - High Priority Should be prioritized into current batch of work. and removed Blocked labels Jul 27, 2020
@jaredlockhart
Copy link
Collaborator Author

*Note change dashes to underscores for the slug

@jaredlockhart
Copy link
Collaborator Author

Just lift this:

https://github.com/mozilla/experimenter/blob/main/app/experimenter/static/rapid/components/experiments/ExperimentDetails.tsx#L180-L187

into here:

https://github.com/mozilla/experimenter/blob/main/app/experimenter/static/rapid/components/experiments/ExperimentDetails.tsx#L86-L101

@tiftran tiftran self-assigned this Jul 27, 2020
tiftran added a commit to tiftran/experimenter that referenced this issue Jul 27, 2020
@tiftran
added analysis report link fixes mozilla#3066
615f9d5
tiftran added a commit to tiftran/experimenter that referenced this issue Jul 28, 2020
@tiftran
added look for completed experiment task fixes mozilla#3066
e9347ca
tiftran added a commit to tiftran/experimenter that referenced this issue Jul 28, 2020
@tiftran
added look for completed experiment task fixes mozilla#3066
b4ebc04
tiftran added a commit that referenced this issue Jul 28, 2020
@tiftran @jaredlockhart
added look for completed experiment task fixes #3066 (#3135)
9eac22d 
Co-authored-by: Jared Lockhart <119884+jaredlockhart@users.noreply.github.com>
github-merge-queue bot pushed a commit that referenced this issue Oct 3, 2023
@dependabot
chore(deps-dev): Bump urllib3 from 2.0.4 to 2.0.6 in /schemas (#9529)
d718af5 
Bumps [urllib3](https://github.com/urllib3/urllib3) from 2.0.4 to 2.0.6.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/urllib3/urllib3/releases">urllib3's
releases</a>.</em></p>
<blockquote>
<h2>2.0.6</h2>
<ul>
<li>Added the <code>Cookie</code> header to the list of headers to strip
from requests when redirecting to a different host. As before, different
headers can be set via <code>Retry.remove_headers_on_redirect</code>.
(GHSA-v845-jxx5-vc9f)</li>
</ul>
<h2>2.0.5</h2>
<ul>
<li>Allowed pyOpenSSL third-party module without any deprecation
warning. <a
href="https://redirect.github.com/urllib3/urllib3/issues/3126">#3126</a></li>
<li>Fixed default <code>blocksize</code> of <code>HTTPConnection</code>
classes to match high-level classes. Previously was 8KiB, now 16KiB. <a
href="https://redirect.github.com/urllib3/urllib3/issues/3066%3E">#3066</a></li>
</ul>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a
href="https://github.com/urllib3/urllib3/blob/main/CHANGES.rst">urllib3's
changelog</a>.</em></p>
<blockquote>
<h1>2.0.6 (2023-10-02)</h1>
<ul>
<li>Added the <code>Cookie</code> header to the list of headers to strip
from requests when redirecting to a different host. As before, different
headers can be set via
<code>Retry.remove_headers_on_redirect</code>.</li>
</ul>
<h1>2.0.5 (2023-09-20)</h1>
<ul>
<li>Allowed pyOpenSSL third-party module without any deprecation
warning. (<code>[#3126](urllib3/urllib3#3126)
&lt;https://github.com/urllib3/urllib3/issues/3126&gt;</code>__)</li>
<li>Fixed default <code>blocksize</code> of <code>HTTPConnection</code>
classes to match high-level classes. Previously was 8KiB, now 16KiB.
(<code>[#3066](urllib3/urllib3#3066)
&lt;https://github.com/urllib3/urllib3/issues/3066&gt;</code>__)</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/urllib3/urllib3/commit/262e3e332209ee93ff70e2b13502c8f20c105ac8"><code>262e3e3</code></a>
Release 2.0.6</li>
<li><a
href="https://github.com/urllib3/urllib3/commit/644124ecd0b6e417c527191f866daa05a5a2056d"><code>644124e</code></a>
Merge pull request from GHSA-v845-jxx5-vc9f</li>
<li><a
href="https://github.com/urllib3/urllib3/commit/740380c59ca2a7c2dceca19e5dba99f6b7060e62"><code>740380c</code></a>
Bump cryptography from 41.0.3 to 41.0.4 (<a
href="https://redirect.github.com/urllib3/urllib3/issues/3131">#3131</a>)</li>
<li><a
href="https://github.com/urllib3/urllib3/commit/d9f85a749488188c286cd50606d159874db94d5f"><code>d9f85a7</code></a>
Release 2.0.5</li>
<li><a
href="https://github.com/urllib3/urllib3/commit/d41f4122966f7f4f5f92001ad518e5d9dafcc886"><code>d41f412</code></a>
Undeprecate pyOpenSSL module (<a
href="https://redirect.github.com/urllib3/urllib3/issues/3127">#3127</a>)</li>
<li><a
href="https://github.com/urllib3/urllib3/commit/b6c04cb3e62ef5a0e4947d037c12fb3ca79e024a"><code>b6c04cb</code></a>
Fix a link to &quot;absolute URI&quot; definition (<a
href="https://redirect.github.com/urllib3/urllib3/issues/3128">#3128</a>)</li>
<li><a
href="https://github.com/urllib3/urllib3/commit/af7c78fa30f5a4e265911371d0c59b6baeddca0f"><code>af7c78f</code></a>
refactor: change double conditional to one (<a
href="https://redirect.github.com/urllib3/urllib3/issues/3118">#3118</a>)</li>
<li><a
href="https://github.com/urllib3/urllib3/commit/34c13c8e68df6f89890ba08b9fc4fbf87ed21669"><code>34c13c8</code></a>
Refer to current internet standards in docs on proxies (<a
href="https://redirect.github.com/urllib3/urllib3/issues/3124">#3124</a>)</li>
<li><a
href="https://github.com/urllib3/urllib3/commit/a3e94f218cd8297db73302eadae235f0c832a809"><code>a3e94f2</code></a>
Fix a name of an attribute in docs (<a
href="https://redirect.github.com/urllib3/urllib3/issues/3125">#3125</a>)</li>
<li><a
href="https://github.com/urllib3/urllib3/commit/da69d4f4f95bc7ef9307fc8e0499c2121f1e4791"><code>da69d4f</code></a>
Fix docs build (<a
href="https://redirect.github.com/urllib3/urllib3/issues/3123">#3123</a>)</li>
<li>Additional commits viewable in <a
href="https://github.com/urllib3/urllib3/compare/2.0.4...2.0.6">compare
view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=urllib3&package-manager=pip&previous-version=2.0.4&new-version=2.0.6)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)
You can disable automated security fix PRs for this repo from the
[Security Alerts
page](https://github.com/mozilla/experimenter/network/alerts).

</details>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
github-merge-queue bot pushed a commit that referenced this issue Oct 3, 2023
@dependabot
chore(deps): Bump urllib3 from 2.0.4 to 2.0.6 in /cirrus/server (#9528)
1272d8d 
Bumps [urllib3](https://github.com/urllib3/urllib3) from 2.0.4 to 2.0.6.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/urllib3/urllib3/releases">urllib3's
releases</a>.</em></p>
<blockquote>
<h2>2.0.6</h2>
<ul>
<li>Added the <code>Cookie</code> header to the list of headers to strip
from requests when redirecting to a different host. As before, different
headers can be set via <code>Retry.remove_headers_on_redirect</code>.
(GHSA-v845-jxx5-vc9f)</li>
</ul>
<h2>2.0.5</h2>
<ul>
<li>Allowed pyOpenSSL third-party module without any deprecation
warning. <a
href="https://redirect.github.com/urllib3/urllib3/issues/3126">#3126</a></li>
<li>Fixed default <code>blocksize</code> of <code>HTTPConnection</code>
classes to match high-level classes. Previously was 8KiB, now 16KiB. <a
href="https://redirect.github.com/urllib3/urllib3/issues/3066%3E">#3066</a></li>
</ul>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a
href="https://github.com/urllib3/urllib3/blob/main/CHANGES.rst">urllib3's
changelog</a>.</em></p>
<blockquote>
<h1>2.0.6 (2023-10-02)</h1>
<ul>
<li>Added the <code>Cookie</code> header to the list of headers to strip
from requests when redirecting to a different host. As before, different
headers can be set via
<code>Retry.remove_headers_on_redirect</code>.</li>
</ul>
<h1>2.0.5 (2023-09-20)</h1>
<ul>
<li>Allowed pyOpenSSL third-party module without any deprecation
warning. (<code>[#3126](urllib3/urllib3#3126)
&lt;https://github.com/urllib3/urllib3/issues/3126&gt;</code>__)</li>
<li>Fixed default <code>blocksize</code> of <code>HTTPConnection</code>
classes to match high-level classes. Previously was 8KiB, now 16KiB.
(<code>[#3066](urllib3/urllib3#3066)
&lt;https://github.com/urllib3/urllib3/issues/3066&gt;</code>__)</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/urllib3/urllib3/commit/262e3e332209ee93ff70e2b13502c8f20c105ac8"><code>262e3e3</code></a>
Release 2.0.6</li>
<li><a
href="https://github.com/urllib3/urllib3/commit/644124ecd0b6e417c527191f866daa05a5a2056d"><code>644124e</code></a>
Merge pull request from GHSA-v845-jxx5-vc9f</li>
<li><a
href="https://github.com/urllib3/urllib3/commit/740380c59ca2a7c2dceca19e5dba99f6b7060e62"><code>740380c</code></a>
Bump cryptography from 41.0.3 to 41.0.4 (<a
href="https://redirect.github.com/urllib3/urllib3/issues/3131">#3131</a>)</li>
<li><a
href="https://github.com/urllib3/urllib3/commit/d9f85a749488188c286cd50606d159874db94d5f"><code>d9f85a7</code></a>
Release 2.0.5</li>
<li><a
href="https://github.com/urllib3/urllib3/commit/d41f4122966f7f4f5f92001ad518e5d9dafcc886"><code>d41f412</code></a>
Undeprecate pyOpenSSL module (<a
href="https://redirect.github.com/urllib3/urllib3/issues/3127">#3127</a>)</li>
<li><a
href="https://github.com/urllib3/urllib3/commit/b6c04cb3e62ef5a0e4947d037c12fb3ca79e024a"><code>b6c04cb</code></a>
Fix a link to &quot;absolute URI&quot; definition (<a
href="https://redirect.github.com/urllib3/urllib3/issues/3128">#3128</a>)</li>
<li><a
href="https://github.com/urllib3/urllib3/commit/af7c78fa30f5a4e265911371d0c59b6baeddca0f"><code>af7c78f</code></a>
refactor: change double conditional to one (<a
href="https://redirect.github.com/urllib3/urllib3/issues/3118">#3118</a>)</li>
<li><a
href="https://github.com/urllib3/urllib3/commit/34c13c8e68df6f89890ba08b9fc4fbf87ed21669"><code>34c13c8</code></a>
Refer to current internet standards in docs on proxies (<a
href="https://redirect.github.com/urllib3/urllib3/issues/3124">#3124</a>)</li>
<li><a
href="https://github.com/urllib3/urllib3/commit/a3e94f218cd8297db73302eadae235f0c832a809"><code>a3e94f2</code></a>
Fix a name of an attribute in docs (<a
href="https://redirect.github.com/urllib3/urllib3/issues/3125">#3125</a>)</li>
<li><a
href="https://github.com/urllib3/urllib3/commit/da69d4f4f95bc7ef9307fc8e0499c2121f1e4791"><code>da69d4f</code></a>
Fix docs build (<a
href="https://redirect.github.com/urllib3/urllib3/issues/3123">#3123</a>)</li>
<li>Additional commits viewable in <a
href="https://github.com/urllib3/urllib3/compare/2.0.4...2.0.6">compare
view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=urllib3&package-manager=pip&previous-version=2.0.4&new-version=2.0.6)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)
You can disable automated security fix PRs for this repo from the
[Security Alerts
page](https://github.com/mozilla/experimenter/network/alerts).

</details>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tiftran tiftran

Labels
Enhancement new / change to feature or function https://mozilla.github.io/task-defect-enhancement/index.html P1 - High Priority Should be prioritized into current batch of work. Web UI
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jaredlockhart @tdsmith @tiftran