Update "rejecting this review" copy to "rejecting the request to {actionDescription}" #5927
Assignees
Labels
Comments
lmorchard
added a commit
that referenced
this issue
Jul 13, 2021
Because:
* we want to add UI to enable manual enrollment end
This commit:
* add isEnrollmentPaused to GQL experiment input for consistency with
serialized experiment type, mapped to is_paused in Django model
* update "rejecting this review" copy to "rejecting the request to
{actionDescription}"
* refactors handling of strings describing lifecycle review flows, moves
all the strings into shared constants
* refactors the Settings page and ChangeApprovalOperations components
* adds more exhaustive stories for launch, end enrollment, and end cases
on PageSummary
* reworks rejection reason display to more properly use old_status and
old_status_next to determine what kind of review was rejected
* adds more status-based logic to make the correct GQL queries on
approval / rejection of review
lmorchard
added a commit
that referenced
this issue
Jul 13, 2021
Because:
* we want to add UI to enable manual enrollment end
This commit:
* add isEnrollmentPaused to GQL experiment input for consistency with
serialized experiment type, mapped to is_paused in Django model
* update "rejecting this review" copy to "rejecting the request to
{actionDescription}"
* refactors handling of strings describing lifecycle review flows, moves
all the strings into shared constants
* refactors the Settings page and ChangeApprovalOperations components
* adds more exhaustive stories for launch, end enrollment, and end cases
on PageSummary
* reworks rejection reason display to more properly use old_status and
old_status_next to determine what kind of review was rejected
* adds more status-based logic to make the correct GQL queries on
approval / rejection of review
Co-authored-by: Lauren Zugai <lauren@zugai.com>
lmorchard
added a commit
that referenced
this issue
Jul 14, 2021
Because:
* we want to add UI to enable manual enrollment end
This commit:
* add isEnrollmentPaused to GQL experiment input for consistency with
serialized experiment type, mapped to is_paused in Django model
* update "rejecting this review" copy to "rejecting the request to
{actionDescription}"
* refactors handling of strings describing lifecycle review flows, moves
all the strings into shared constants
* refactors the Settings page and ChangeApprovalOperations components
* adds more exhaustive stories for launch, end enrollment, and end cases
on PageSummary
* reworks rejection reason display to more properly use old_status and
old_status_next to determine what kind of review was rejected
* adds more status-based logic to make the correct GQL queries on
approval / rejection of review
Co-authored-by: Lauren Zugai <lauren@zugai.com>
lmorchard
added a commit
that referenced
this issue
Jul 14, 2021
Because:
* we want to add UI to enable manual enrollment end
This commit:
* add isEnrollmentPaused to GQL experiment input for consistency with
serialized experiment type, mapped to is_paused in Django model
* add support for isEnrollmentPausePending to indicate when the review
is in progress
* rework useChangeOperationMutation to indicate loading while awaiting
experiment refetch
* update "rejecting this review" copy to "rejecting the request to
{actionDescription}"
* refactors handling of strings describing lifecycle review flows, moves
all the strings into shared constants
* refactors the Settings page and ChangeApprovalOperations components
* adds more exhaustive stories for launch, end enrollment, and end cases
on PageSummary
* reworks rejection reason display to more properly use old_status and
old_status_next to determine what kind of review was rejected
* adds more status-based logic to make the correct GQL queries on
approval / rejection of review
Co-authored-by: Lauren Zugai <lauren@zugai.com>
lmorchard
added a commit
that referenced
this issue
Jul 14, 2021
Because:
* we want to add UI to enable manual enrollment end
This commit:
* add isEnrollmentPaused to GQL experiment input for consistency with
serialized experiment type, mapped to is_paused in Django model
* add support for isEnrollmentPausePending to indicate when the review
is in progress
* rework useChangeOperationMutation to indicate loading while awaiting
experiment refetch
* update "rejecting this review" copy to "rejecting the request to
{actionDescription}"
* refactors handling of strings describing lifecycle review flows, moves
all the strings into shared constants
* refactors the Settings page and ChangeApprovalOperations components
* adds more exhaustive stories for launch, end enrollment, and end cases
on PageSummary
* reworks rejection reason display to more properly use old_status and
old_status_next to determine what kind of review was rejected
* adds more status-based logic to make the correct GQL queries on
approval / rejection of review
Co-authored-by: Lauren Zugai <lauren@zugai.com>
lmorchard
added a commit
that referenced
this issue
Jul 14, 2021
Because:
* we want to add UI to enable manual enrollment end
This commit:
* add isEnrollmentPaused to GQL experiment input for consistency with
serialized experiment type, mapped to is_paused in Django model
* add support for isEnrollmentPausePending to indicate when the review
is in progress
* rework useChangeOperationMutation to indicate loading while awaiting
experiment refetch
* update "rejecting this review" copy to "rejecting the request to
{actionDescription}"
* refactors handling of strings describing lifecycle review flows, moves
all the strings into shared constants
* refactors the Settings page and ChangeApprovalOperations components
* adds more exhaustive stories for launch, end enrollment, and end cases
on PageSummary
* reworks rejection reason display to more properly use old_status and
old_status_next to determine what kind of review was rejected
* adds more status-based logic to make the correct GQL queries on
approval / rejection of review
Co-authored-by: Lauren Zugai <lauren@zugai.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Confirmed by Ana, when a user is rejecting a review we want to change "this review" to
the request to ${actionDescription}.┆Issue is synchronized with this Jira Task
The text was updated successfully, but these errors were encountered: