Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serialization is being called multiple times #9741

Closed
eliserichards opened this issue Nov 14, 2023 · 0 comments · Fixed by #9742
Closed

Serialization is being called multiple times #9741

eliserichards opened this issue Nov 14, 2023 · 0 comments · Fixed by #9742
Assignees

Comments

@eliserichards
Copy link
Contributor

eliserichards commented Nov 14, 2023

It looks like the NimbusReviewSerializer validation is being called multiple times on save:

serialization-error.mov

Steps to repro:

  1. Create a draft experiment
  2. Add all info needed to ensure no other review errors are thrown (fill out the overview and audience pages)
  3. On the Branches page, select a feature
  4. Fill in branch names and descriptions
  5. Add a deeply nested feature configuration, e.g.:
{
  "sections-enabled": {
    "hello": 1
  }
}
  1. Click save

Expected results:
The serialization (and FML validation) is called once and the correct error message is shown

Actual results:
The serialization is being pinged continuously, and we're seeing variation in the UI from the different error messages from the FML

┆Issue is synchronized with this Jira Task

eliserichards added a commit to eliserichards-mozilla/experimenter that referenced this issue Nov 14, 2023
…istic and that is triggering the serialization repeatedly
eliserichards added a commit to eliserichards-mozilla/experimenter that referenced this issue Nov 14, 2023
…istic and that is triggering the serialization repeatedly
eliserichards added a commit to eliserichards-mozilla/experimenter that referenced this issue Nov 14, 2023
…istic and that is triggering the serialization repeatedly
eliserichards added a commit to eliserichards-mozilla/experimenter that referenced this issue Nov 14, 2023
…istic and that is triggering the serialization repeatedly
github-merge-queue bot pushed a commit that referenced this issue Nov 14, 2023
Because

- Some of the FML errors are coming in different orders

This commit

- Removes the error message from the serialization for now, but still
logs them

Fixes #9741
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant