Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nimbus): Include localizations field in v7 api #10722

Merged
merged 1 commit into from
May 22, 2024
Merged

Conversation

brennie
Copy link
Member

@brennie brennie commented May 16, 2024

Because:

  • Skylight needs access to the localizations field in the v7 API

This commit:

  • Adds the localizations field to the v7 API

Fixes #10719

Copy link
Collaborator

@jaredlockhart jaredlockhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yep looks good but prolly need to update tests?

Because:

- Skylight needs access to the localizations field in the v7 API

This commit:

- Adds the localizations field to the v7 API

Fixes #10719
@brennie brennie force-pushed the dev/v7-l10n branch 2 times, most recently from 311576b to 6701eae Compare May 21, 2024 18:08
Copy link
Collaborator

@jaredlockhart jaredlockhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 💯 🎉 💯 🎉 💯 🎉 💯 🎉 💯 🎉 💯

@brennie brennie added this pull request to the merge queue May 22, 2024
Merged via the queue into main with commit 71fd499 May 22, 2024
20 checks passed
@brennie brennie deleted the dev/v7-l10n branch May 22, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

localizations not present in v7 API
2 participants