Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(nimbus): persist theme switcher in new nimbus ui #10791

Merged
merged 1 commit into from
Jun 13, 2024
Merged

feat(nimbus): persist theme switcher in new nimbus ui #10791

merged 1 commit into from
Jun 13, 2024

Conversation

jaredlockhart
Copy link
Collaborator

Because

  • We are implementing the new Nimbus UI in bootstrap 5 which supports light/dark themes
  • We can add a toggle to switch themes
  • We should persist the chosen theme

This commit

  • Persists the chosen theme in localstorage
  • Defaults to system light/dark theme

fixes #10685

Screen.Recording.2024-06-03.at.17.55.17.mov

@jaredlockhart
Copy link
Collaborator Author

@brennie Okay ya good points, let's do this then. I'll set up better static asset management in #10708 and then we can do as you say, move this to a script, lint it, stick it in the static build pipeline, etc. So I'll mark this as blocked until I get that stuff in next.

@jaredlockhart
Copy link
Collaborator Author

We'll be able to rebase this after #10834 lands

@jaredlockhart
feat(nimbus): persist theme switcher in new nimbus ui
3f16322 
Because

* We are implementing the new Nimbus UI in bootstrap 5 which supports light/dark themes
* We can add a toggle to switch themes
* We should persist the chosen theme

This commit

* Persists the chosen theme in localstorage
* Defaults to system light/dark theme

fixes #10685
brennie
brennie approved these changes Jun 13, 2024
View reviewed changes
Copy link
Member

@brennie brennie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, this is great with the new bundling stuff

@jaredlockhart jaredlockhart added this pull request to the merge queue Jun 13, 2024
@jaredlockhart
Copy link
Collaborator Author

Ya so easy to just add a little page specific script 🙏

Merged via the queue into main with commit 75b3866 Jun 13, 2024
20 checks passed
@jaredlockhart jaredlockhart deleted the 10685 branch June 13, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brennie brennie brennie approved these changes

@yashikakhurana yashikakhurana Awaiting requested review from yashikakhurana yashikakhurana is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Persist light/dark settings
2 participants
@jaredlockhart @brennie