fix #5739 feat(nimbus): trigger kinto update from publish status #5935
Conversation
Because * We want updates to live experiments to be triggered by users manually * This only current live update is pausing an experiment * In the future we will support updating other fields for live experiments This commit * Removes the automatically triggered pause update logic * Refactors the live update kinto logic to be triggered by publish status the same way launch/end are * Refactors the V5 API to look at published_dto to determine if enrollment is ended * Updates the NimbusExperimentFactory to update published_dto after each live update * Updates the kinto diagrams to include setting is_paused from the UI to make frontend integration clearer for the current end enrollment flow
| @property | ||
| def is_paused_published(self): | ||
| return bool(self.published_dto and self.published_dto.get("isEnrollmentPaused")) |
There was a problem hiding this comment.
Ah, cool, this pattern looks generically handy for determining when particular updates have gotten published
There was a problem hiding this comment.
Exactly yeah the more we switch things over to doing live updates, we'll need a way to distinguish unpublished/published changes. We might want something fancier like a proper revision system or something in the future, but for now this minimally works.
| self.assertEqual( | ||
| data, | ||
| { | ||
| "application": experiment.application, | ||
| "channel": experiment.channel, | ||
| "feature_config": { |
There was a problem hiding this comment.
Nothing really changed here besides popping out the nested data for a separate comparison below, right?
There was a problem hiding this comment.
Yeah I don't know why the feature_config suddenly started complaining, but I had to move things around to add the published_dto comparison and then feature_config started being cranky? But no I didn't change anything with it.
Because
This commit